Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few config issues #73

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Fix a few config issues #73

merged 3 commits into from
Sep 14, 2024

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Sep 14, 2024

  1. Fixes subcats having their category name twice in the langkey & stops subcats from having their lang key set multiple times.
  2. Makes @Config.Comment applicable to classes so that you can put the annotation on the subcat class instead of their field & add comments for non-subcategories
  3. Adds the -Dgtnhlib.printkeys jvm flag to print lang keys generated from @Config.LangKeyPattern in the log.

@Lyfts Lyfts requested a review from a team September 14, 2024 11:21
@boubou19
Copy link
Member

tested in GTNewHorizons/GT5-Unofficial#3169 and everything works now thx.

@boubou19 boubou19 merged commit 5d611ae into master Sep 14, 2024
1 check passed
@boubou19 boubou19 deleted the config-fixes branch September 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants